Trim whitespaces when creating a RepositoryAttribute#437
Conversation
Magnus-Kuhn
added
wip
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Magnus-Kuhn
removed
the
wip
Magnus-Kuhn
requested review from
Milena-Czierlinski,
britsta,
jkoenig134 and
sebbi08
packages/consumption/src/modules/attributes/AttributesController.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
For the ProposeAttributeRequestItemProcessor, logic for the RepositoryAttribute duplicates will be added in the future and the code for the RepositoryAttribute duplicates in the ReadAttributeRequestItemProcessor (#423) will be adapted/refactored, right? Then I understand the PR description to mean that the trimming of whitespace in these two cases should be implemented in a separate PR after the other changes have been made. 😊
Edit: I saw that the PR description has been updated, so the question has been answered. :D
.../modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.test.ts
Show resolved
Hide resolved
britsta
left a comment
britsta
left a comment
There was a problem hiding this comment.
One last small comment, rest LGTM.
packages/consumption/test/modules/requests/itemProcessors/createAttribute/Context.ts
Outdated
Show resolved
Hide resolved
…teAttribute/Context.ts Co-authored-by: Britta Stallknecht <[email protected]>
|
is this a breaking change? I don't think so, right? |
nope, it's not |
|
@Magnus-Kuhn please take care of the merge conflicts here :) |
Magnus-Kuhn
dismissed stale reviews from Milena-Czierlinski and britsta
via
e52cb66
packages/consumption/test/modules/requests/itemProcessors/createAttribute/Context.ts
Outdated
Show resolved
Hide resolved
4 participants
Readiness checklist
Notes
Since the CreateAttributeRequestItem has the most sophisticated processing, it also has more detailed tests than the Propose- and ReadAttributeRequestItems. They will need to be adapted once the Propose- and ReadAttributeRequestItemProcessors are updated.